Results 31 comments of Brian Bergeron

Still needed, will do after https://github.com/MetaMask/metamask-mobile/pull/9110

@salimtb I spoke to the shared libraries devs at office hours. Their recommendation was to make a breaking change to move to the new structure, rather than maintain backwards compatibility...

Be sure to update PR description/title to reflect the broader market data being added. Since it's more than just the daily % change now.

This is a good idea, and MetaMask should support longer symbol lengths. There are other parts of the codebase that would need to be updated. At least [here](https://github.com/MetaMask/core/blob/624dba9f646635d5c167ae590ac41cdf374d6196/packages/assets-controllers/src/TokensController.ts#L829) but maybe...

Looks like the eth-overview buttons were recently refactored. Merged that in.

@metamaskbot update-policies

I suspect a fix is needed in `SelectedNetworkController`. This code to remove deleted network client IDs from dapp domains no longer triggers, since it expects a patch to `networkConfigurations` but...

@metamaskbot publish-preview

@mikesposito The only remaining thing I can't figure out, is an error `Cannot perform 'get' on a proxy that has been revoked` on various places that call `getNetworkConfigurationByNetworkClientId`. The easiest...

@metamaskbot publish-preview