Brian Bergeron
Brian Bergeron
Generally looks good to me! Love that we can get more information in fewer requests
> Do you know if this is a recent regression? I'm not seeing this in production. Flagging @NidhiKJha for review. Correct. This occurs on `develop`, not the current prod release....
Since the linked PR was checked in a few days ago this should not be in 11.8 or any release yet. I did attempt a fix here, which worked for...
I haven't been able to get this modal to appear yet. Maybe my process is wrong, and not sufficient to simulate the upgrade. I imported a fresh build from `develop`...
@metamaskbot update-policies
Hmmm the e2e tests failing in CI are passing locally
I'm confused by the e2e test failures. They keep passing locally in both browsers, and should be unrelated to the changes. - `Success on testcase: 'Wallet Created Events @no-mmi are...
I'm not super familiar with the controller messaging patterns to determine if they're all correct. But I don't see anything that looks wrong! 🚀
A related thing I want to fix separately. We run detection 3 times when switching chains: - On network controller switching chains - On token list changing 1st time (on...
@metamaskbot update-policies