Make the valid Token Symbol Length Parametric

[miladtsx]

This pull request is to resolve issue #9243.

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[miladtsx]

I have read the CLA Document and I hereby sign the CLA

[matrixise]

ping

[github-actions[bot]]

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

[github-actions[bot]]

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

[github-actions[bot]]

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

[github-actions[bot]]

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

[miladtsx]

Ping ping friendly ping :)

[github-actions[bot]]

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

[github-actions[bot]]

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

[Sopyaylin]

Uploading OKX Account Statement - Dec 2023.pdf…

[fredwes]

Hey @legobeat , is this PR ready to merge?

[fredwes]

Is there anything I can do to help get this merged?

[fredwes]

Sorry to keep bumping here but our users have reported issues adding tokens due to this. @legobeat any update on getting this merged in?

[legobeat]

Sorry to keep bumping here but our users have reported issues adding tokens due to this. @legobeat any update on getting this merged in?

@fredwes Unfortunately, I don't have any further insights on the progress to share at this time.

@MetaMask/extension-devs Could we get some eyes on this, please? Any UI/UX concerns?

[bergeron]

This is a good idea, and MetaMask should support longer symbol lengths. There are other parts of the codebase that would need to be updated. At least here but maybe others. And it would require some UI work to consider every place showing symbols to make sure they render correctly, and do something like an ... ellipses or truncation to make it fit. So I don't think this can be merged as is.

[github-actions[bot]]

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.10%. Comparing base (91dc6ea) to head (8d813c1).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #17642   +/-   ##
========================================
  Coverage    70.10%   70.10%           
========================================
  Files         1430     1430           
  Lines        50147    50148    +1     
  Branches     13872    13872           
========================================
+ Hits         35152    35153    +1     
  Misses       14995    14995           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[miladtsx]

Hey @bergeron, thanks for your feedback. I made some UI adjustments and tested them manually as much as possible.

I also adjusted MetaMask Core to support this change.

Looking forward to your feedback.