metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

New asset details page

Open bergeron opened this issue 9 months ago • 2 comments

New asset details page.

Screenshot 2024-05-10 at 8 23 50 AM

bergeron avatar May 14 '24 16:05 bergeron

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar May 14 '24 16:05 github-actions[bot]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None +1 5.01 MB chartjs-ci
npm/[email protected] None 0 56.9 kB dangreen

View full report↗︎

socket-security[bot] avatar May 14 '24 16:05 socket-security[bot]

@metamaskbot update-policies

bergeron avatar May 17 '24 20:05 bergeron

Policies updated

metamaskbot avatar May 17 '24 20:05 metamaskbot

Codecov Report

Attention: Patch coverage is 65.03856% with 136 lines in your changes missing coverage. Please review.

Project coverage is 65.58%. Comparing base (650bd6c) to head (04d0e2f). Report is 1 commits behind head on develop.

Files Patch % Lines
...i/pages/asset/components/chart/crosshair-plugin.ts 4.17% 23 Missing :warning:
ui/pages/asset/components/token-buttons.tsx 61.02% 23 Missing :warning:
ui/pages/asset/components/token-asset.tsx 4.55% 21 Missing :warning:
ui/pages/asset/components/native-asset.tsx 5.26% 18 Missing :warning:
ui/pages/asset/components/chart/asset-chart.tsx 60.00% 16 Missing :warning:
ui/components/app/wallet-overview/coin-buttons.tsx 84.72% 11 Missing :warning:
ui/pages/asset/components/asset-page.tsx 86.21% 8 Missing :warning:
ui/pages/asset/util.ts 75.00% 5 Missing :warning:
ui/pages/asset/asset.tsx 0.00% 4 Missing :warning:
ui/pages/asset/components/asset-price.tsx 84.00% 4 Missing :warning:
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24522      +/-   ##
===========================================
+ Coverage    65.55%   65.58%   +0.03%     
===========================================
  Files         1353     1361       +8     
  Lines        53936    54140     +204     
  Branches     14070    14162      +92     
===========================================
+ Hits         35353    35504     +151     
- Misses       18583    18636      +53     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 05 '24 03:06 codecov[bot]

Builds ready [34cdc86]
Page Load Metrics (250 ± 286 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7512989136
domContentLoaded8221131
load422301250595286
domInteractive8221131
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 235.78 KiB (3.53%)
  • common: 1.14 KiB (0.02%)

metamaskbot avatar Jun 05 '24 04:06 metamaskbot

Looks like the eth-overview buttons were recently refactored. Merged that in.

bergeron avatar Jun 07 '24 15:06 bergeron

Builds ready [8b0a0b6]
Page Load Metrics (252 ± 291 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint67165922713
domContentLoaded99415189
load412458252605291
domInteractive99415189
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 234.68 KiB (3.50%)
  • common: 1003 Bytes (0.02%)

metamaskbot avatar Jun 10 '24 02:06 metamaskbot

@metamaskbot update-policies

bergeron avatar Jun 10 '24 15:06 bergeron

No policy changes

metamaskbot avatar Jun 10 '24 15:06 metamaskbot

Builds ready [04d0e2f]
Page Load Metrics (41 ± 1 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint67907463
domContentLoaded811910
load38484131
domInteractive811910
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 234.68 KiB (3.50%)
  • common: 1003 Bytes (0.02%)

metamaskbot avatar Jun 10 '24 16:06 metamaskbot