fix: nft detection running too many times

[bergeron]

Description

Fixes an issue where the NFT detection controller was running too many times. It would send an HTTP request to fetch NFTs when any setting changed. It should only do so when the autodetect NFT setting changes.

Porting this core PR to mobile.

Related issues

Manual testing steps

Screenshots/Recordings

Before

https://github.com/MetaMask/metamask-mobile/assets/3500406/bf9ea063-88f8-4712-a426-97c0f23c49b4

After

Pre-merge author checklist

• [ ] I’ve followed MetaMask Coding Standards.
• [ ] I've clearly explained what problem this PR is solving and how it is solved.
• [ ] I've linked related issues
• [ ] I've included manual testing steps
• [ ] I've included screenshots/recordings if applicable
• [ ] I’ve included tests if applicable
• [ ] I’ve documented my code using JSDoc format if applicable
• [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• [ ] I’ve properly set the pull request status:
  • [ ] In case it's not yet "ready for review", I've set it to "draft".
  • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (23dc52b) 41.06% compared to head (2a78be1) 41.06%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8603   +/-   ##
=======================================
  Coverage   41.06%   41.06%           
=======================================
  Files        1247     1247           
  Lines       30351    30351           
  Branches     2963     2963           
=======================================
  Hits        12464    12464           
  Misses      17142    17142           
  Partials      745      745           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[bergeron]

Still needed, will do after https://github.com/MetaMask/metamask-mobile/pull/9110

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[github-actions[bot]]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ca5870e3da7d1672a5d4656e3be5644abc5d163b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1f645a54-c79c-40da-bdd8-7224404bcf5b

[!NOTE]

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request