Björn Rabenstein comments

Results 1096 comments of


                                            Björn Rabenstein

Compactions cause the configured storage.tsdb.retention.size to be exceeded (and risk of running out of disk space)

Hello from the bug scrub! We think this is a relevant issue to fix and would welcome PRs. A mitigation of the issue would be to simply update the docs...

Re-organize overlapping sections (Concepts, Best Practices, Tutorials, Guides, Specifications)

Thanks @henrik-caesar for your offer to help. There is definitely a lot of room for improvement when it comes to docs. Note, however, that this particular issue is not about...

PromQL engine: Delay deletion of name label to the end of the query evaluation

My (unplugged) vacations start ~now. I didn't get to this in time, sorry for that. I guess we should run prombench on this with the latest improvements (but of course,...

PromQL engine: Delay deletion of name label to the end of the query evaluation

I'm finally back from vacations and the subsequent catch-up… Note that we had some interesting discussion on the original issue starting [here](https://github.com/prometheus/prometheus/issues/11397#issuecomment-2255238079). The concerns are valid but we decided to...

PromQL engine: Delay deletion of name label to the end of the query evaluation

@jcreixell could you (temporarily) hard-wire the feature flag to "set" in this PR so that I can trigger another Prombench run? At that same time, it might also be good...

PromQL engine: Delay deletion of name label to the end of the query evaluation

Note for later: https://github.com/prometheus/prometheus/blob/main/docs/feature_flags.md needs an update, too.

PromQL engine: Delay deletion of name label to the end of the query evaluation

/prombench main

PromQL engine: Delay deletion of name label to the end of the query evaluation

/prombench cancel

PromQL engine: Delay deletion of name label to the end of the query evaluation

Prombench looks good. If at all, I can only see a slightly lower CPU usage with this PR, no other noticeable differences. Of course, Pormbench isn't perfectly measuring everything, but...

PromQL engine: Delay deletion of name label to the end of the query evaluation

Will review ASAP (more likely early next week than this week…).