Björn Rabenstein

Results 1096 comments of Björn Rabenstein

The bucket coming from the runtime has an upper exclusive boundary of 25 (or, equivalently, a lower inclusive boundary of 25). An observation at value 25 will therefore end up...

Paging @juliusv . Is this another exception? Intended or accidental?

I can imagine that there are a lot of "nonsensical" queries out there, not created by a human but by some generating program, that "just worked" so far. Those might...

That seems to be an iteration on #5326 . Back then, it was concluded that "when including an on() clause, only labels mentioned in that clause are retained." But with...

Wow, that went really deep… :exploding_head: From my understanding, I would say we should keep the existing behavior, not only to avoid breaking the expectation that has grown over the...

> If on is used with one-to-one matching, the metric name is dropped. … unless you say `on (__name__)`. I think the explanation should be different: If you use `on`...

Thank you. I'm wondering if it would be easier and also clearer if we just made the documentation for the `----http.config.file` flag on the [promtool page](https://prometheus.io/docs/prometheus/latest/command-line/promtool/) more comprehensive, maybe explain...

Yes, I was thinking to put something into the preamble to explain what `--http.config.file` is. But that would mean to make the general help string specified in https://github.com/prometheus/prometheus/blob/2726a18ae361d174274dce673426914ccaf5ac15/cmd/promtool/main.go#L102 much longer....

Thank you. And apologies for the review delay. I'm still caught between several events at work and in my usual life, but I will finally be back at reviewing code...

It has to be part of a release to be visible on the website. Will happen soon.