Björn Rabenstein
Björn Rabenstein
Going through https://github.com/orgs/prometheus/projects/9/views/13 should give more inspiration what to add here (and looking at the changelog, and making sure that all is consistent with each other). Some things I have...
https://github.com/prometheus/prometheus/pull/15092 should be mentioned, too, i.e. the whole "selectors are actually expected to return matching results". This will only affect a few, but because it is so subtle, I would...
The change to log/slog should be mentioned as it changes the logging format. old: ``` ts=2024-10-23T22:01:06.074Z caller=main.go:627 level=info msg="No time or size retention was set so using the default time...
Scrape config option `scrape_classic_histograms` is now called `always_scrape_classic_histograms`.
Hello from the bug scrub! @beorn7 (which is me :duck:) dropped the ball on this, but by now, he isn't maintaining the mixins anymore. @metalmatze we thought you should have...
From a quick glance, it looks like we should rename `PrometheusNotConnectedToAlertmanagers` to something like `PrometheusNoAlertmanagersDiscovered`. If any further descriptions are unclear, they should be updated.
The whole type structure could be improved indeed, but that would require an invasive change, which can only happen with a v2 major release. In the meantime, you could make...
If there are provable better ways of handling thread contention here, I would like to hear (with experimental evidence). My conclusion many years ago was that we needed access to...
Or even 2m, because that's generally the max recommended scrape interval (so you can deal with a missed scrape without running into the lookback delta).
I would think a warning should be issues if the scrape interval is larger than 2m (but it shouldn't be a hard error as there are special scenarios where larger...