Björn Rabenstein
Björn Rabenstein
> [bwplotka](https://github.com/bwplotka) requested a review from [beorn7](https://github.com/beorn7) [last week](https://github.com/prometheus/prometheus/pull/13955#event-12561725681) Generally, this feature looks good to me. For a serious review, I needed to get deeper into the subject, for which...
My thoughts: I think the (float, histogram) args for arithmetic binary operators needs to be broken up. For example, `float + histogram` or `histogram - float` doesn't work, but `float...
The basic idea is this: Where operations and aggregations make sense (between histogram and histogram, or between histogram and float), they happen. Where they don't make sense, the histogram is...
> So the gist here is that after grouping the labels if the vector contains both histogram and float then we'll issue a warning otherwise we will return the min...
> In my opinion if the operation makes sense and something is returned from that operation but we have ignored histogram in the vector ( like 2/foo ) then we...
Sorry for the delay. I'm back from vacation and will try to get to this ASAP. If anyone qualified beats me to it, even better.
In the meantime, @KofClubs could you fix the DCO? It should be easy. See the details of the failed DCO test.
Note that the kind of "filling" being discussed in #13625 is different from the filling here. The filling proposed here is to add samples at certain timestamps to a time...
In this particular case, isn't it most straightforward to use the `for` clause of an alert rule? ```yaml alert: PodNotReady expr: kube_pod_status_ready==0 for: 5m ```