Björn Rabenstein

Results 1096 comments of Björn Rabenstein

@jesusvazquez could you make a call if this approach make sense and @machine424 should continue to refine it?

> I'd like to add it to gitignore (in another PR). Let's not add files specific to certain IDEs or editors to .gitignore. Those files should be in your personal...

Yes, and it will (only) be closed once v3.0.0 has been released with those feature flags removed.

Sorry, I guess you wanted to know if this is still free to work on… I guess it is, and it is indeed an easy one. I guess we will...

Then take your time and explore the code a bit. You could first search the code base to find where the feature flag mentioned in this issue are processed. From...

Ummm, now that I look at this issue more closely, there is already a PR doing the thing, see #13456 linked above. So I guess that means this issue is...

The PR #13456 is not merged yet because that can only happen once we have a v3 release branch. Not sure if it would be better to close this issue...

An important note: In contrast to the text-based exposition formats, PromQL also allows single quotes and backticks as quoting characters in addition to double quotes. See https://prometheus.io/docs/prometheus/latest/querying/basics/#string-literals For the new-style...

A less important note: I find it a bit problematic to use "new" as a part of the names here. For one, it is usually used in factory functions in...

Thanks @NeerajGartia21 . I'll try this out ASAP. @Nexucis could you check in the meantime if all your comments have been addressed?