Björn Rabenstein comments

Results 1096 comments of


                                            Björn Rabenstein

UTF-8: updates UI parser to support UTF-8 characters

I don't understand enough about `GroupingLabels` in the UI to make a call. @Nexucis @ywwg WDYT? In any case, you could address the remaining comment in the meantime. We'll see...

UTF-8: updates UI parser to support UTF-8 characters

@Nexucis could you have a look? I'm still completely lost when it comes to the frontend parts.

Converts existing native histogram unit tests to the PromQL testing framework

Thanks, I'll have a look ASAP.

Converts existing native histogram unit tests to the PromQL testing framework

@NeerajGartia21 are you still working on this? Do you need more help?

Converts existing native histogram unit tests to the PromQL testing framework

That looks weird indeed. Could you push your current version of the code (that runs into the error above)? Then I might take part in the mystery hunt (if I...

Converts existing native histogram unit tests to the PromQL testing framework

I found the problem, https://github.com/prometheus/prometheus/pull/13854. Please review. :)

Converts existing native histogram unit tests to the PromQL testing framework

BTW: The histogram comparison relies on exact float matches rather using `almostEqual`. If that turns out to be a problem with any of the other tests, we should keep that...

Converts existing native histogram unit tests to the PromQL testing framework

OK, so after a rebase, you should get this working.

Converts existing native histogram unit tests to the PromQL testing framework

I'll try to get to this ASAP, but currently, I'm sick.

Converts existing native histogram unit tests to the PromQL testing framework

No, there isn't. Back then, we decided that the grammar of the testing framework doesn't have to be that powerful. This particular test might be one that we don't want...