Björn Rabenstein comments

Results 1096 comments of


                                            Björn Rabenstein

web/api add limit param

Requesting review from @bboreham as the author of the original proposal #12795 .

[Coverity CID: 347187] Out-of-bounds access in arch/common/shared_irq.c

@ArthurSens would you be interested in working on this? @bwplotka @krajorama FYI.

[Coverity CID: 347187] Out-of-bounds access in arch/common/shared_irq.c

Given that's only happening if you activate both feature flags at the same time, I doubt it's super urgent. But user reports will tell. :)

[Coverity CID: 347187] Out-of-bounds access in arch/common/shared_irq.c

If a histogram is a counter-like histogram, CT applies in the same way as for float counters. The same way as a zero float sample is inserted into a series...

[Coverity CID: 347187] Out-of-bounds access in arch/common/shared_irq.c

yes. just use the Go zero value. We might need to check that a schema change or a change of the zero bucket doesn't trigger a new chunk if it...

promtool: add a "tsdb dump-openmetrics" to dump in OpemMetrics format.

@bboreham @dgl will you be able to finish the review on this one?

remove the `remote-write-receiver` flag from `enable-feature`

And we can only merge that one once we actually release v3 (or have a release branch for v3, in which we can merge it).

fix(discovery): make discovery manager notify consumers of dropped targets for still defined jobs

@roidelapluie are you able to finish the review on this?

Update Go module directive to v2

Wasn't the whole idea of making the module version appear as 0.y.z that we don't suggest any API stability on the Go level? In other words, if we went to...

Update Go module directive to v2

As said, I'm happy with the current state. As also said above already, this should be discussed at the dev-summit. Please add a topic to the agenda if you want...