Björn Rabenstein

icon indicating an email [email protected]

icon company @grafana icon location Berlin icon location @prometheus developer working at @grafana. Alumnus of @soundcloud and @google. Hope is not a strategy – but it springs eternal.

Results 1096 comments of Björn Rabenstein

discovery: kubernetes: Avoid creating unnecessary Kubernetes indexers…

Merging this with @bboreham 's approval. @brancz please shout if you see any issues here.

Implement New Metric Type for Constant Value Metrics to Optimize Storage in Prometheus

Thanks for your thoughts. I would almost definitely avoid an introduction of a specific new metric type for constant values. (But note that OpenMetrics has an _info_ type, whose "value"...

discovery: kubernetes: reduce informers' cache footprint.

@brancz could you have a look?

Prometheus built from source in directory not called "prometheus" doesn't work

This seems to be in the React part. @Nexucis could you have a look?

Convert existing native histogram unit tests to the PromQL testing framework

I recommend to pick a single unit test first and convert it to get familiar with the procedure.

Convert existing native histogram unit tests to the PromQL testing framework

Thanks. I have assigned this to you. Let me know if you have any questions.

Convert existing native histogram unit tests to the PromQL testing framework

Yes. And then delete the corresponding Go unit test code.

nhcb: add optional field to prometheus remote write protobuf definition for custom bucket specification

> What will be the semantics of `Histogram.reset_hint` protobuf field in this new use case? There should be no change in semantics. What makes you think there would be one?

nhcb: add optional field to prometheus remote write protobuf definition for custom bucket specification

> I guess in this case, for this new internal representation of classic histogram, a change in behaviour (vs. old school bucket storage in individual series) would be that reset...

[Coverity CID: 347081] Division or modulo by zero in drivers/sensor/tmag5273/tmag5273.c

@bboreham does this look good to you now? @machine424 assuming @bboreham's comments are addressed, merge conflicts need to get resolved, and then we can merge.