Ben Wilson

Results 158 comments of Ben Wilson

This is the main issue. `non_null(:order_placed)`. Fields that return errors should not be marked `non_null`. When you return an error on the field, its value is always null. When a...

Hi @mathieuprog, Absinthe itself does not introduce any timeouts. Can you show a complete example that I can run?

Hi @dmarkow good catch. This behaviour exists from before extensions were part of the GraphQL spec. I'm fine aiming to change this in 1.6, with the aim to create some...

Thanks! So I've sort of reproduced this in https://github.com/absinthe-graphql/absinthe/pull/1072, but if you look at the test failure the `data` field is actually doing the right thing already today. It's missing...

Yes I have not had time to look into this further, you're welcome to take a crack at it. Null propagation happens in https://github.com/absinthe-graphql/absinthe/blob/master/lib/absinthe/phase/document/execution/resolution.ex#L43-L75

This is a great change, can you add a changelog entry?

@elbow-jason hey thanks! I'll have to look at this more closely but it does look like tests are failing in the CI, do you see them passing locally?

I do not have time to dive into this, so @SvenW if you have time to look at the blueprints generated by both SDL and regular schemas that'd be the...

This is definitely not helpful, but I'm not sure what alternative there is. If you're using the default adapter the name from the document `"Foo"` is run through the `Macro.underscore`...