absinthe icon indicating copy to clipboard operation
absinthe copied to clipboard

Changes misnamed `:__absinthe_type_import__` to `:__absinthe_type_imports__` in Schema.Notation

Open elbow-jason opened this issue 2 years ago • 3 comments

This PR changes a (probably) misnamed module attribute registered during the compilation of use Schema.Notation.

Closes #1119

Signed-off-by: Jason Goldberger [email protected]

elbow-jason avatar Nov 15 '21 21:11 elbow-jason

@elbow-jason hey thanks! I'll have to look at this more closely but it does look like tests are failing in the CI, do you see them passing locally?

benwilson512 avatar Nov 16 '21 13:11 benwilson512

@benwilson512 They are most definitely not passing locally. This PR needs a little more love before it's ready.

elbow-jason avatar Nov 17 '21 22:11 elbow-jason

I think the existing behavior was intended, and the fact that the accumulating attribute was mis-spelled was actually what made it work correctly, since the code seems to manually manage the "default" empty list case...

binaryseed avatar Nov 22 '21 03:11 binaryseed