Ben Wilson

Results 239 comments of Ben Wilson

Seconding this. As a library author with packages that depend on Poison I honestly don't know what constraint to put. Everything seems to work at all the versions, but `"~>...

Everyone should just move to Jason at this point really.

I think the right path here is a relatively simple `batching: false` option we enable on the plug. Per our conversation on slack, a temporary work around could be to...

Hey @glasser thanks for the heads up. Definitely something we should look into. I want to avoid reinventing the wheel within the Elixir ecosystem, since CSRF concerns are generally handled...

The blocker here is whether Dataloader can "see through" associations on a schema to determine that they have equivalent SQL that will be run. Not sure if this is doable.

It's a lot less fragile if instead the options are passed in directly: ``` Dataloader.load(loader, Post, {:replies, %{some_option: true}}, post) ```

> I would now like to override run_batch to override the way this association is loaded You can do this: ``` def run_batch(Fusebox.Fuse, query, :fuses, fuse_boxes, repo_opts) do # run...

Closing in favor of https://github.com/absinthe-graphql/dataloader/pull/148

Handled now in 1.0.11. To use, make sure that when you call `Dataloader.new/1` you do: ``` loader = Dataloader.new(async?: !MyApp.Repo.in_transaction?()) ``` This will be handled automatically in 2.0