Ben Wilson

Results 158 comments of Ben Wilson

This is unfortunately a function of the obnoxious rules that AWS has in and around the AWS S3 API. Basically it's just `s3-$region.amazonaws.com` unless the region is `us-east-1`, and then...

It actually looks like the `presigned_url` logic is out of date too, since it doesn't appear to be using the same logic that all the actual requests use. Let me...

http://docs.aws.amazon.com/cli/latest/userguide/cli-chap-getting-started.html#cli-environment In OS X or linux you would put those `export` lines in your `~/.bash_profile` or `~/.bashrc`. I'm not sure what you do on windows.

virtual_host is only used by the presign_url function.

`virtual_host: true` merely places the bucket in the domain name. This is never necessary. It can always go: http://s3.$aws_host.com/bucket_name/object/path if in us-east-1 or http://s3-$region.$aws_host.com/bucket_name/object/path if not in us-east-1

I would avoid hard coding your access key id or secret key, they both can be picked up from your environment variables. I'm not sure I understand why this is...

@thecodeboss that solves the issue of reconnecting, but any metrics calls that happen between when it fails and when it restarts will raise. The inability to send a metric shouldn't...

I do think that's a solution, but I also think that wrapping the port operations in a `try` is critical as well. Even in the best case reconnection isn't instant,...

Right, this is a good question. Here's the issue generally: Right now middleware doesn't work with subscription `config` at all. The reason is simple: Middleware runs during the resolution phase,...

@jcelliott PR welcome for that note!