Ben McCann

Results 1534 comments of Ben McCann

For this particular case where we've made no changes to the AST, could we avoid re-printing it and writing it to the file?

Yes, I meant that since we already know it's an issue we shouldn't have to wait for the user to make selections. We could do this as a special check...

oh, I just noticed that this is a bit of a duplicate of https://github.com/svelte-add/svelte-add/issues/356

I got a handful of errors like the below when testing against the `web` folder of immich. I also got one about some invalid HTML which printed a similar stacktrace...

It fails to migrate `$$Props`, which I didn't know existed until I tried to run it on a project that had it and it bombed out :laughing: https://www.reddit.com/r/sveltejs/comments/1778zq4/interface_props_mentioned_in_the_svelte_5_post/

The `Unexpected token` error could be clearer. It says `line: 60, column: 33`, but it's quite buried and I missed that. I only saw it after sticking that file into...

I filed issues at https://github.com/sveltejs/svelte/issues/13178 and https://github.com/sveltejs/svelte/issues/13179

I think we could arguably print a better error when encountering an error for the parse case or `$$Props` cases above. Ideally we're able to fix those in Svelte and...

> These are problems that need solving within Svelte itself, not here The problems themselves should be solved in Svelte, but I'm talking about more general handling of unexplained exceptions....

I wasn't suggesting to change the text of the error messages, but to nicely print the col/row number which are buried right now and to suppress the stack trace (maybe...