Ben McCann

Results 1525 comments of Ben McCann

I'm sorry, I'm afraid I don't. Feel free to close it if no one wants to take it over

thanks! i'm not sure why this didn't get merged. I guess we lost it in the queue. But I'm going to go ahead and close it as it's done now:...

It should work. One more suggestion: you can replace `isGlob` with `isDynamicPattern` from `tinyglobby`, so that you don't need an additional library for that

> Allow to control which assets are compressed. Something like {formats: [html, svg, js, css]} What's the usecase for that?

More ideas for configuration here: https://github.com/sveltejs/kit/pull/1693#issuecomment-861483732 I'd rather keep things on the simple side though

> Looks like html, js, json, css, svg, xml are currently compressed. Actually the code has `['.html', '.js', '.mjs', '.json', '.css', '.svg', '.xml', '.wasm']`. Yes, it could make sense to...

Vitest is another fairly lightweight option for jest-compatible test runner. My last experience was that Jest is terrible to use with ESM as it doesn't fully support it yet. vitest...

Yeah, I think if you click through to see how it was originally done it was with `globStream`

Immich is another project that we can switch over to tinyglobby once we have `globStream`

Here's the issue in `fdir` that this depends on: https://github.com/thecodrr/fdir/issues/40