Ben McCann

Results 1525 comments of Ben McCann

If we did do this it would need to be added to the documentation. I'm not sure if needs to be in the playground though The main question I have...

@geigerzaehler thanks for this. I went through all the dependency updates today and updated vitest to version 2, which changed all the snapshot files. Can you rebase this PR against...

Looks like `cspell` had to rollback their switch to `tinyglobby` due to this not being present: https://github.com/streetsidesoftware/cspell/pull/6167#issuecomment-2416571901

I'm just going off the comment there: > The issues is with the ignore option. If it contains a glob starting with ! no results are returned. Perhaps I misunderstood...

Making it consistent with fast-glob would really help with migrating users over from that library, so sounds like a good idea to me.

What does a negated ignore pattern even mean? Ignore everything except it? But in that case, why don't you just pass it as the main pattern without the negation? Oh,...

>I wonder if we even need to include the dependency at all. I looked at argon2 to see how its used and its just a single function export: Compare https://npmgraph.js.org/?q=argon2...

I sent https://github.com/vercel/nft/pull/431 to upgrade `argon2`. I'm not sure what else is required to address this issue, but I believe this new version of argon2 should hopefully address the blockers...

I see. That makes much more sense to me. Thanks! It's not exactly clear to me that `find` is easily replaceable though it would be awesome if someone can figure...

`argon2` switched from `@mapbox/node-pre-gyp` to `node-gyp-build` here: https://github.com/ranisalt/node-argon2/commit/b47602840a259946039db8526ddd182d1430f634#diff-bc704b883867dea430073059d0e3061c8ac87c037826b06007646f667777916d The latter library is dramatically lighter. I wonder if we could make the same switch here