webpack-dev-server icon indicating copy to clipboard operation
webpack-dev-server copied to clipboard

Update chokidar to v4

Open Fuzzyma opened this issue 11 months ago • 7 comments

Bug report

This is not a bug report but I didn't know where to put it. I would like to propose updating chokidar to v4. This would reduce the dependency count by 11 and also improves typing. I am opening this issue as part of the ecosystem cleanup initiative (https://e18e.dev). We are trying to modernize the ecosystem by reducing dependency bloat, package size or improve speed.

If you are open for this, I would be happy to create a PR and do the necessary changes!

Actual Behavior

Expected Behavior

How Do We Reproduce?

Please paste the results of npx webpack-cli info here, and mention other relevant information

Fuzzyma avatar Dec 04 '24 17:12 Fuzzyma

@Fuzzyma I am afraid we can't do it right now, due - https://github.com/paulmillr/chokidar/releases/tag/4.0.0

Remove glob support

It will be breaking change for us

alexander-akait avatar Dec 05 '24 14:12 alexander-akait

Ah I see. I actually faced the same problem over at tailwindcss. One community member (@talentlessguy) suggested this solution:

chokidar.watch(paths.map(p => isGlob(p) ? tinyglobby(p) : p))

Would that maybe work?

Fuzzyma avatar Dec 05 '24 14:12 Fuzzyma

@Fuzzyma This can work, need to test if it will work with creating nested directories, but I think it should

alexander-akait avatar Dec 05 '24 14:12 alexander-akait

It should work. One more suggestion: you can replace isGlob with isDynamicPattern from tinyglobby, so that you don't need an additional library for that

benmccann avatar Dec 05 '24 17:12 benmccann

When looking into this I hit a blocker with chokidar and would like to wait for the resolution before I put more work into it.

// EDIT:

Ok, with the fix that I proposed to chokidar I made it work. If the change to chokidar is not accepted I need to add a small workaround. Will create a PR for review tomorrow

Fuzzyma avatar Dec 07 '24 17:12 Fuzzyma

Hey I am Interested in this issue, How to get started

Anubhab2003 avatar Jan 03 '25 07:01 Anubhab2003

@Anubhab2003 a pr already exists and is ready to be merged. Nothing to do here :D

Fuzzyma avatar Jan 03 '25 07:01 Fuzzyma