tinyglobby icon indicating copy to clipboard operation
tinyglobby copied to clipboard

Published 20 hours ago • verified publisher icon SuperchupuDev

`globStream` support

Open benmccann opened this issue 1 year ago • 5 comments

I saw this requested in https://github.com/webpro-nl/knip/issues/768

benmccann avatar Aug 25 '24 18:08 benmccann

it is possible to add (fdir exposes an option for it), but i'm not sure about adding extra options just because they could be useful for some (that's how libraries get bloated, right?). i feel like the proper fix would be to add globStream

SuperchupuDev avatar Aug 25 '24 19:08 SuperchupuDev

Yeah, I think if you click through to see how it was originally done it was with globStream

benmccann avatar Aug 25 '24 19:08 benmccann

Immich is another project that we can switch over to tinyglobby once we have globStream

benmccann avatar Oct 07 '24 21:10 benmccann

Seems like fdir is lacking any such support, however

etnoy avatar Oct 07 '24 22:10 etnoy

Here's the issue in fdir that this depends on: https://github.com/thecodrr/fdir/issues/40

benmccann avatar Oct 07 '24 22:10 benmccann

I wonder if this could be implemented now that fdir uses AbortController. See:

  • https://github.com/SuperchupuDev/tinyglobby/issues/134
  • https://github.com/thecodrr/fdir/pull/110
  • https://github.com/thecodrr/fdir/pull/144

benmccann avatar Jun 26 '25 17:06 benmccann

i don't think it can be easily implemented here until fdir itself adds streams support

SuperchupuDev avatar Jun 26 '25 17:06 SuperchupuDev

Oh yeah, I guess aborting early isn't the same as streaming. But it might be enough for knip to switch to tinyglobby at least as I think they were primarily concerned with early return. I'm not sure about Immich

benmccann avatar Jun 28 '25 13:06 benmccann

Here's another one that uses streaming: https://www.npmjs.com/package/@compodoc/compodoc

benmccann avatar Sep 15 '25 17:09 benmccann