Ben Jeffery

Results 132 comments of Ben Jeffery

~The `HTTPResponse` doesn't support `seek`, so won't work. Not all fileno's are equal.~ EDIT: This was very wrong.

Ah, I understand now. After failing to read the kastore, tskit tries to load as h5py, and that's when it tries to seek. So yes, something weird here.

I've tracked this down a bit - as tskit's python interface is taking the file descriptor of the `HTTPResponse` and then reopening it in the C API, it is getting...

No, not planning to fix soon. Tracked it down as unexplained behaviour is always concerning!

https://github.com/tskit-dev/tszip/issues/66

Having been through this process over at `tskit` I can recommend adding a minimal `pre-commit` configuration in a PR, then adding additional rules one-by-one in separate PRs. This makes it...

@JereKoskela what version of tskit are you using? Pip won't upgrade it unless asked and the dev requirements might need a pin. `python -m pip install --upgrade tskit`

Sounds like we need a pin. Will raise an issue!

> I'm guessing the repl form is quite old, predating the systematic use of sphinx. Happy to remove Agreed!

Don't think this is a bad idea - what code do you have where this is good and what is the alternative?