Ben Jeffery

Results 132 comments of Ben Jeffery

Great idea, would be quite a nice thing for a contributor to do as it is pure python and the C routines can be used a reference. I don't see...

This is a perfect candidate for a dynamic notebook widget, where you click a node to toggle summarisation. One day!

On a quick glance I would agree with having the collapsing be done in the drawing code rather than in the tree sequence. This also allows you to do fancy...

Cool! I'm guessing in the general case you'd want to expand/collapse the layout though?

Is it clear what those operations should exactly do with the reference? I'm tempted to say here that those methods should error in the presence of a reference, at least...

Thanks @hyanwong, I've added this to the metadata project for when we design out the API.

Happy with this idea - although I think it is trivial to check against the schema and worth doing. I'd add a `force` argument to override the check.

I think the simplest thing here is to remove `custom_max`. I've done this in https://github.com/tskit-dev/tskit/commit/a3aa3da8f2ba991a48967011a230a32cf6fe62cd Currently, I've set the `N` numbers to those generated when `custom_max` was `15`. Once all...

> I added this argument because some of my changes in this PR make IbdFinder run much more slowly, to the point where they look like they're hanging. (This is...