Access the left and right of an edge as an interval

[hyanwong]

Is this useful at all, or just an extra maintenance burden?

[benjeffery]

Don't think this is a bad idea - what code do you have where this is good and what is the alternative?

[codecov[bot]]

Codecov Report

Merging #2531 (4de1dfd) into main (2f32cde) will increase coverage by 11.75%. The diff coverage is 66.66%.

@@             Coverage Diff             @@
##             main    #2531       +/-   ##
===========================================
+ Coverage   82.15%   93.90%   +11.75%     
===========================================
  Files          27       27               
  Lines       26925    27198      +273     
  Branches     1255     1265       +10     
===========================================
+ Hits        22119    25541     +3422     
+ Misses       4714     1623     -3091     
+ Partials       92       34       -58     

Flag	Coverage Δ
c-tests	92.24% <ø> (ø)
lwt-tests	89.05% <ø> (ø)
python-c-tests	73.16% <50.00%> (-0.01%)	:arrow_down:
python-tests	98.94% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
python/tskit/trees.py	98.69% <66.66%> (+52.25%)	:arrow_up:
python/tskit/provenance.py	100.00% <0.00%> (+5.71%)	:arrow_up:
python/tskit/tables.py	98.95% <0.00%> (+14.68%)	:arrow_up:
python/tskit/metadata.py	99.02% <0.00%> (+19.18%)	:arrow_up:
python/tskit/util.py	100.00% <0.00%> (+44.66%)	:arrow_up:
python/tskit/combinatorics.py	99.36% <0.00%> (+57.87%)	:arrow_up:
python/tskit/stats.py	100.00% <0.00%> (+64.86%)	:arrow_up:
python/tskit/genotypes.py	99.04% <0.00%> (+67.46%)	:arrow_up:
python/tskit/drawing.py	98.99% <0.00%> (+87.98%)	:arrow_up:
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f32cde...4de1dfd. Read the comment docs.

[hyanwong]

Don't think this is a bad idea - what code do you have where this is good and what is the alternative?

I needed to quickly check whether a tree covered a whole edge. tree.interval == edge.interval seems more comprehensible than tree.right == edge.right and tree.left == edge.left, but it's not exactly a priority!

[benjeffery]

Oh! That's a nice example. Seems like a good addition.

[benjeffery]

Converting this to a draft as it needs tests.

[hyanwong]

Yeah, meant to open as a draft, sorry.