Ben Jeffery

Results 132 comments of Ben Jeffery

I agree that it would be better to have this be a named method, rather than doing sneaky modification on assingment. We should add a helpful message to the error...

I'm reopening this as we haven't done assignment, but also haven't decided to not do it!

Yes, I'm happy with this, and with the idea that the C API defines what is metadata/data. Especially as we start to standardise metadata, I see it that there are...

Some more up-to-date notes as this issue got posted as dupe in #2294. This is very close to https://github.com/tskit-dev/tskit/issues/2239 where there is a proposal for the `TreeSequence` row-accessors to get...

I've attempted to fix all trees and figures see, e.g. https://benjeffery.github.io/tskit-site/tskit/docs/latest/topological-analysis.html I'm trying a method where they can still be black-on-white for printout. Tables are fixed. Left to fix -...

> Looks nice. I wonder if the page titles in the forwards and backwards links at the bottom of the page should be all in the light green, rather than...

I'm now happy with this, we can merge now, or wait till tskit-book-theme is on PyPI after I've checked it on the other repos.

> Sounds good. Can we try this out on a "beta" build of the website before it all goes fully live? It's already part of the demo site at https://benjeffery.github.io/tskit-site/tskit/docs/latest/introduction.html

@jeromekelleher Can I get a review here? I'm ready to start merging the doc PRs now that the site is ready and `tskit-book-theme` has been released on PyPI.