Ben Allen

Results 73 comments of Ben Allen

> it's worth bringing up again now that the sender checks that use the `ensure!` macro do not get picked up by `cargo mutants` as explained in [#539 (comment)](https://github.com/payjoin/rust-payjoin/issues/539#issue-2854127569). It...

Transitioning these tests to use just `assert_eq` has certainly made them nice and readable! I would like to maybe use `expect_err` instead of `unwrap_err` just for some easier debugging when...

I think it's Ok to tag onto #339 as there is already some discussion there about these test there. As for creating a higher level [ ] has many unit...

I found the comment in receive for the "why" but it seems to have been removed, IMO i would like it to be included somewhere ``` // 4M block size...

After work on #1077 we realized that perhaps we want to move towards our own implementation of payjoin::Url instead of trying to marry the url crate with our halfway approach....

#1121 should close this issue but does not remove the url crate as a dep. I think we should make a new issue for that as it seems outside of...

I have started building out `v2_to_v1` it's almost there, I just have 2 functions to bring over the ffi layer

How "dangerous" is this localStorage leak? if its not I guess just changing the name as a prefix is simple enough ``` const storageKey = `{$userID}__webln:provider:nwc` const configStr = window.localStorage.getItem(storageKey).split("__")[1]...

I will try my hand at this, a lot of these issues look like they are some good practice on rust fundamentals on when and where to use references, Copy...