Ben Allen

Still have some stypling to do but WoW!  @sfr0xyz Definitely want to pay you half of this PR, I would have been working on this for ages had I...

Setting a dynamic height has proven more difficult than I anticipated using the https://njump.me/embed/$ script. It has logic for setting maxHeight to 50vh but since the `src.setAttribute('height', px)` logic is...

Here is the relevant debug log. It seems like while the connection is established with the relay it seems to not pool the idle connection the first time and this...

> Is that an appropriate change tho? I'm actually not sure what place in our code we could change the log status for this, I think it is occurring in...

BIP78 sender checklist test coverage - [x] Verify that the absolute fee of the payjoin proposal is equals or higher than the original PSBT. `test_absolute_fee_less_than_original_psbt()` - [x] If the receiver's...

Are we satisfied that `test_process_proposal_when_payee_output_has_disallowed_output_substitution()` is sufficient in its completeness even though it doesn't look exactly for a uri param and simply assumes pjos=0 works as expected. I would say...

`test_output_substitution` ensures some additional mutants do not occur, I merged them both together into the existing `test_process_proposal_when_payee_output_has_disallowed_output_substitution()` test and added some comments to clarify what is occuring.

__Archived__ check #339 for the updated checklist Checklist for review (These checks are not confirming that the logic in each test is sound, just organization and completeness) - [x] Verify...

A few questions and comments - Do we think its necessary to have some tests follow the checklist as closely as possible? `test_process_proposal_when_payee_output_has_disallowed_output_substitution()` as an example does not parse the...

Its rather disappointing `bitcoin::psbt::Error` is the only thing holding us back from being able to apply `PartialEq, Eq` on the `InternalProposalError` enum