Ben Allen

Results 73 comments of Ben Allen

Since using this `#[allow(public_interfaces)]` + `#[doc(hidden)]` approach won't work with our .msrv is it ok to make the InternalError variants public as well while keeping them doc hidden like I...

I am obviously setting up my PAT secret incorrectly. @spacebear21 any insight on what this failure indicates? I couldn't really find anything on it. We want this runner to use...

I need to come back to this, I totally forgot it existed. I think the issue I was having had to do with trying to simplify this down to an...

A follow-up question, where is an appropriate place to actually pad this message to equal the array length of the `PADDED_PLAINTEXT_A/B_LENGTH`

After testing this a little more I was able to get up to 24 senders, after which the test-wallet ran out of bitcoin, so perhaps this comment / whole test...

> My guess is that the v2 tests are relying on the URI builder from v1. We may need another builder that's v2-specific OR to expose this utility without feature...

Following #1126 We still have `url/idna` through our `bhttp` dep which is enabling its `http` feature through `dep:http` in `payjoin/_core`

Ok, I have this branch If we want it, https://github.com/payjoin/rust-payjoin/commit/fd63fca4571950554e0b39f8e43bca0547d52763 Here is the [ubuntu-latest](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md) runner readme, `build-essentials` and `python3-dev` are not baked in but its possible we were using them...

For some reference I know that Primal uses `noteId` vs what appears to be the more standard `nEvent` so we would likely need to have at least 2 ways to...

I'll check it out! I rolled my own from standard nostr-tools functions but I'll see if this is better for us