rust-payjoin icon indicating copy to clipboard operation
rust-payjoin copied to clipboard

Audit public API to take arguments by reference where possible before v1.0 release

Open spacebear21 opened this issue 1 year ago • 6 comments

Don't consume values unless there is a reason for doing so. Make sure that arguments which take ownership of a value do so intentionally.

Search for .clone() in integration tests...

spacebear21 avatar Nov 20 '24 20:11 spacebear21

I will try my hand at this, a lot of these issues look like they are some good practice on rust fundamentals on when and where to use references, Copy traits and whatnot

benalleng avatar Jan 08 '25 21:01 benalleng

@benalleng please pick up from #405 if you're up for it. Lots of small PRs will let us crank forward progress on this one. I'm not tied to getting #405 in myself, it was really a way for us to enumerate problems where we saw them when we were in person

DanGould avatar Jan 08 '25 21:01 DanGould

Hey @DanGould @spacebear21 I'd like to work on this issue

bc1cindy avatar Aug 15 '25 19:08 bc1cindy

This got auto-closed by #982 but I guess the issue should still be open

spacebear21 avatar Aug 21 '25 16:08 spacebear21

Renamed to narrow the scope of this issue.

spacebear21 avatar Aug 21 '25 16:08 spacebear21

Right before we release we should audit and check if we are taking refrences when we can.

arminsabouri avatar Sep 08 '25 17:09 arminsabouri