Does ubuntu-latest image need a build dependency installation step

[benalleng]

I added a few sudo commands in our generate_bindings.sh script file in our python in an attempt to simplify the workflow file in https://github.com/payjoin/rust-payjoin/commit/363d2b5446993782711bc1af8b4dc5126c8c1475 not really considering that this script is not only being run by a github runner but rather should also be run on local dev machines as well.

Should we return this step back to the workflow for our ubuntu-latest runner image?

- name: "Install build dependencies"
  run: |
    sudo apt update
    sudo apt install -y build-essential python3-dev

https://github.com/payjoin/rust-payjoin/commit/363d2b5446993782711bc1af8b4dc5126c8c1475#diff-092659a9bd0068791326fb1d08f005532e5aeb983b999a7bd32c51deee0a71d5L40-L43

It clearly is not preventing workflows from failing following its removal in #1000. I am curious if someone has some insight on its purpose at all? I see that it looks like it may have simply appeared when we pulled ffi into the monorepo in cd3ad4730c029c252bcfa60886f9ffebd9fb1b8b

https://github.com/payjoin/rust-payjoin/commit/cd3ad4730c029c252bcfa60886f9ffebd9fb1b8b#diff-815ba4bb400db19ee2163135e803799582cec49b3a88fdc1855c583a8af83344R37-R40

[DanGould]

yes

[spacebear21]

I don't see why ubuntu-latest runners even need this, since python CI is passing currently? Just removing those entirely seems fine.

[benalleng]

Ok, I have this branch If we want it, https://github.com/payjoin/rust-payjoin/commit/fd63fca4571950554e0b39f8e43bca0547d52763

Here is the ubuntu-latest runner readme, build-essentials and python3-dev are not baked in but its possible we were using them in the past but aren't anymore?