rust-payjoin Ns1r integration test does not fail with greater than 4 senders

according to this comment 4 should be the max number of senders possible but the test does not fail when senders is set to 5.

https://github.com/payjoin/rust-payjoin/blob/361c31e5627aec721eccf1e6e1042618adf94038/payjoin/tests/integration.rs#L747-L750

Apr 15 '25 19:04 benalleng

Interesting... I distinctly remeber hitting a max payload size. I guess there are some variables that could change this behavior like numbers of inputs every senders is contributing

Apr 15 '25 20:04 arminsabouri

After testing this a little more I was able to get up to 24 senders, after which the test-wallet ran out of bitcoin, so perhaps this comment / whole test needs another look to make sure something else flaky isn't happening.

Apr 15 '25 20:04 benalleng

Do we have an actual payload size validation

Apr 16 '25 07:04 Johnosezele

Do we have an actual payload size validation

Yes IIRC this is a policy on the directory

Edit: its also checked by the receiver when they are decapsulating the ohttp responses

Apr 16 '25 13:04 arminsabouri

NS1R was removed from rust-payjoin #923

Sep 18 '25 16:09 arminsabouri