Benjamin E. Coe

Results 350 comments of Benjamin E. Coe

@felipecrs I'm wondering if we could avoid adding an additional configuration option, what if you passed the commits through a transform stream and remove the scope: ``` class PostProcessCommits extends...

> Apart from the implementation suggestion, are you saying that we should automatically omit the scope if the user defined a scope for the type? @felipecrs because there are so...

@felipecrs I'll make an effort to pull together an example 👍 _sorry for the slow reply._

@Mesteery this would be a breaking change. Perhaps you could instead pass in a custom template for your use case?

@Mesteery funny enough, I think for release-please we pass our own templates, so this wouldn't actually correct the template in its case.

@MunifTanjim I went ahead and landed #618, is there still anything from this PR that we need?

@MunifTanjim 👍 any tests we could add for the `FIXME`, that you can think of? spooks me a little bit just because it removes a lot of code (but perhaps...

@SuperITMan sorry that we dropped this PR on the floor. @dudekaa I agree that I think we could figure out a slight rework of `commit.subject.replace` and address the problem.

@SuperITMan thanks for updating the PR 👍 will try to help merge some of these PRs soon.

@kellyselden when you have a moment, could I bother you to rebase.