Benjamin E. Coe
Benjamin E. Coe
@jedwards1211 mind giving the `next` release of `nyc` a spin, to make sure this is still an issue: `npm cache clear; npm i nyc@next` We just landed a few patches...
@jedwards1211 👍 yes, would love a reproduction in `istanbul-reports`, we can get this patched ASAP.
@songjiachao Istanbuljs supports any platform that can run JavaScript, you just need to instrument the code before running it, at which point you can collect coverage information.
@songjiachao I think it would be worth opening an issue on `rollup-plugin-istanbul`, and/or `vite-plugin-istanbul`. Istanbul just instruments JavaScript for coverage, and has some helpers for processing source maps. There are...
> any plan to support vite? To answer the original question. No, but if there are any bugs or features that need to be implemented to support a third-party tool...
Just started looking at this repo a little bit again 👍 will make an effort to give this review.
somewhat related, I just added a badge to shields.io that reads Istanbul config files: https://dev.to/bcoe/enforce-javascript-code-coverage-with-github-actions-36lg
I see no reason not to remove `javascript:void(0);` from our reports, if we do so anywhere.
@elliot-nelson this seems like a great feature, sorry for the slow review. I'm supportive of this refactor, but would like to test thoroughly with all the existing summarizers on a...
@marceloavf @piranna for what it's worth, I've been using [c8](https://github.com/bcoe/c8) these days for my projects that are ESM. It's not perfect, but I find it works well enough for me.