Benjamin E. Coe

Results 350 comments of Benjamin E. Coe

> Not opposed to this, but it is a change (might be breaking even?) from the current spec. I think I've made a few breaking changes as we transcribe the...

@Tiberriver256, I wonder if @juanpicado or @JaKXz might have a project you can crib as an example -- it sounds like we might potentially need to update help, if the...

@juanpicado @securedeveloper I'd be happy to put a istanbul-typescript-demo in the istanbuljs organization. perhaps join the slack and we can coordinate work? http://devtoolscommunity.herokuapp.com/

@BboyAkers anything jump out to you with regards to the AppVeyor failure?

> Should I upgrade node versions? I'd suggest that we upgrade the Node version and switch to a GitHub action configuration similar to c8 (rather than using AppVeyor). But, if...

> Gotcha and agreed! I can take a stab at upgrading the node version today and create a new PR @BboyAkers sounds good, looking forward to the PR. Feel free...

@kraenhansen thanks for the contribution. It looks like a few tests are failing, do you see this locally?

> @bcoe this is my contribution; I'm looking into the failure right now! My bad sorry, I was half paying attention, and it was @kraenhansen who reached out to me.

@nwalters512 two options: 1. I'd be fine with skipping those tests. 2. Alternatively, what I've done in the past is remove values from the string that's about to be snapshot...

@nwalters512 the process tree is pretty niche, I'm comfortable with commenting out these tests as long as the majority of tests work that exercise core behaviour.