Benjamin E. Coe

Results 350 comments of Benjamin E. Coe

> Guy's what this coverage is all about? Code which we wrote and use right? Or it is related to testing. Please tell I'm interested to work on this. Hey...

👋 I'm having trouble starting the Tooling Group meeting, due to this issue, I get what looks like an OTP entry, but I'm not seeing how I would take over...

@mhdawson like so? https://github.com/nodejs/email/pull/189

@mountaindude sorry for this nuisance, I've bumped into this myself recently I believe. Could I bother you to open a ticket on the main [release-please](https://github.com/googleapis/release-please) repository?

> But it looks like release-please then only looks for conventional commits in ./src. The path variable was added as a way to initially support repos that release multiple packages...

@jacobrheath in the sample you've shared here, it doesn't look like you're using the `src/` argument to point to an alternate folder. Could you describe to me the issue you're...

@zishan0 is the repository that this is happening on public or private?

@ChristianIvicevic the problem is that Node.js defaults to `v1.0.0` if no prior release can be found. If you create a release pointing to your main branch, with the tag `v0.1.0`,...

@wraithgar I don't believe we intentionally removed this functionality in the parent `release-please`, but we should make sure it's supported before we document the config setting.

@chingor13 happen to know if `changelog-type` is again supported?