release-please-action icon indicating copy to clipboard operation
release-please-action copied to clipboard

Failing with "Error: release-please failed: Not Found" when "release-type: node"

Open zishan0 opened this issue 2 years ago • 4 comments

The action fails for release-type as node, but works with python(tested with simple as well) in organisation accounts.

The release-type node fails in organisation accounts but works in personal user account.

image

Update the error message to be more precise which would help in debugging such issues.

zishan0 avatar Sep 02 '21 15:09 zishan0

@zishan0 is the repository that this is happening on public or private?

bcoe avatar Sep 07 '21 21:09 bcoe

@bcoe > @zishan0 is the repository that this is happening on public or private?

Same here and it's happening on private repository

dancardonaortiz avatar Sep 17 '21 19:09 dancardonaortiz

This was happening because I did not have the package.json file present in the main branch when the release-type was node. This happens both for public and private repositories. It works when there is no pyproject.toml file when using release-type as python. We probably need better error message when it fails due to this reason and maybe even fix it to allow it to work when package.json is not present.

zishan0 avatar Sep 20 '21 07:09 zishan0

It happens the same in rust when there is no Cargo.toml for the workspace. See here for this repo. But even if I add it nothing changes, so maybe I am missing something else, too. I also tried running the CI with --debug but it doesn't help

MarcoIeni avatar Dec 18 '21 19:12 MarcoIeni