release-please-action icon indicating copy to clipboard operation
release-please-action copied to clipboard

Release-please aborted due to untagged, merged release PRs

Open mountaindude opened this issue 3 years ago • 3 comments

TL;DR

"‼ There are untagged, merged release PRs outstanding - aborting" is the last line of release-please output in GitHub Actions log. Happens in RPA v3 but not in v2.

I kind of understand what an untagged release PR is... but I can't find any such PRs. And how can I fix the issue? And avoid it happening again?

It has happened for several repos when moving from v2 to v3 of Release-Please-Action, leaving those repos in a less than desired state when it comes to CI workflows.

Expected behavior

  1. I expect a release PR to be created, based on the commit messages I've used since last release was done.
  2. I expect the log output from RPA to reflect the config I use in the Action YAML file.
  3. I expect the PR title pattern to be taken from the config in the Action YAML rather than from elsewhere

Observed behavior

  1. RPA runs but eventually aborts with "‼ There are untagged, merged release PRs outstanding - aborting"
  2. The logs indicate that some other pull request title pattern is used. Note: I do have a RPA manifest file in the repo (from previous tests with using manifest files), but with "release-type: simple" that manifest file should not be used by RPA.
  3. The log complains TWICE about pullRequesttitlePattern not being correct. But I am not even specifying this in the Action YAML config.

Action YAML

Note: steps.extract_sp.outputs.servicepack is set in previous step. 
If the branch name triggering the action to run is "dev/sp3", servicepack will be "sp3".
-------------------------

      - name: Run Release-Please
        uses: google-github-actions/release-please-action@v3
        id: release
        with:
          release-type: simple
          package-name: TEST_${{ steps.extract_sp.outputs.servicepack }}
          default-branch: dev/${{ steps.extract_sp.outputs.servicepack }}
          monorepo-tags: false
          changelog-types: '[{"type":"feat","section":"Features","hidden":false},{"type":"fix","section":"Bug Fixes","hidden":false},{"type":"docs","section":"Documentation","hidden":false},{"type":"refactor","section":"Refactored","hidden":false},{"type":"doc","section":"Documentation","hidden":false},{"type":"chore","section":"Miscellaneous","hidden":false},{"type":"ci","section":"CI/CD","hidden":false}]'
          fork: false
          clean: true

Log output

Run google-github-actions/release-please-action@v3
  with:
    release-type: simple
    package-name: TEST_sp5
    default-branch: dev/sp5
    monorepo-tags: false
    changelog-types: [{"type":"feat","section":"Features","hidden":false},{"type":"fix","section":"Bug Fixes","hidden":false},{"type":"docs","section":"Documentation","hidden":false},{"type":"refactor","section":"Refactored","hidden":false},{"type":"doc","section":"Documentation","hidden":false},{"type":"chore","section":"Miscellaneous","hidden":false},{"type":"ci","section":"CI/CD","hidden":false}]
    fork: false
    clean: true
    token: ***
    bump-minor-pre-major: false
    bump-patch-for-minor-pre-major: false
    draft: false
    draft-pull-request: false
  env:
    GITHUB_REF: refs/heads/dev/sp5
    GITHUB_EVENT_NAME: push
√ Looking for latest release on branch: dev/sp5 with prefix: 
‼ Could not find releases.
√ Building releases
√ Building strategies by path
√ Looking at files touched by path
√ Building release for path: .
‼ pullRequestTitlePattern miss the part of '${scope}'
‼ pullRequestTitlePattern miss the part of '${component}'
‼ pullRequestTitlePattern miss the part of '${version}'
× Bad pull request title: 'Pending UAT release : 🔖 sp5 release TEST_sp5 3.0.1'
√ Looking at files touched by path
‼ pullRequestTitlePattern miss the part of '${scope}'
√ Building release for path: .
‼ pullRequestTitlePattern miss the part of '${component}'
‼ pullRequestTitlePattern miss the part of '${version}'
× Bad pull request title: 'Pending UAT release (dev/sp5): 🔖 sp5 release TEST_sp5 2.2.0'

√ Looking for latest release on branch: dev/sp5 with prefix: 
‼ Could not find releases.
√ Building pull requests
√ Building strategies by path
√ Collecting release commit SHAs
‼ Could not find releases.
‼ Expected 1 releases, only found 0
‼ Missing 1 paths: .
‼ No version for path .
‼ Expected 1 releases, only found 0
√ Collecting commits since all latest releases
√ Splitting 500 commits by path
√ Building candidate release pull request for path: .
‼ No latest release pull request found.
√ Considering: 49 commits
‼ There are untagged, merged release PRs outstanding - aborting

Additional information

I've battled this for some time now, trying to use manifests and finally now also deleted all previous tags and releases. Which makes the scan through the repo to take quite some time, which is reflected in the log output above.

mountaindude avatar Feb 22 '22 14:02 mountaindude

Tried removing the two manifest files in the repo - problem remains with same log output.

mountaindude avatar Feb 22 '22 14:02 mountaindude

Tried removing all releases, tags and branches (except the dev/sp3 branch that triggers the Action), then doing a manual bootstrap using release-please CLI. Same error as before.

The error message does indicate that some already merged release PRs are untagged, but why is that an issue? And how should they be tagged? What tags are missing on them?

mountaindude avatar Feb 22 '22 16:02 mountaindude

@mountaindude sorry for this nuisance, I've bumped into this myself recently I believe.

Could I bother you to open a ticket on the main release-please repository?

bcoe avatar Mar 20 '22 14:03 bcoe

The upstream issue is fixed. Closing?

tmatsuo avatar Oct 04 '22 23:10 tmatsuo

I using multiple subdirectories and the issue is happening in my github action, but am unsure how to fix it? I have tried the same steps as mentioned above. My experience "monorepos" is non exiting and I am unsure if it could be caused by my .release-please-manifest or the

✔ Considering: 458 commits
❯ component:
❯ pull request title pattern: undefined
❯ Found pull request #100: 'chore: release main'
⚠ There are untagged, merged release PRs outstanding - aborting

My manifest and config files looks like this:

.release-please-manifest:
{
  "backend": "1.1.0",
  "frontend": "1.1.0"
}

release-please-config:

{
  "packages": {
    "backend": {
      "changelog-path": "CHANGELOG.md",
      "bump-minor-pre-major": false,
      "bump-patch-for-minor-pre-major": false,
      "draft": false,
      "release-type": "node",
      "prerelease": false,
      "package-name": "package.json"
    },
    "frontend": {
      "changelog-path": "CHANGELOG.md",
      "bump-minor-pre-major": false,
      "bump-patch-for-minor-pre-major": false,
      "draft": false,
      "release-type": "node",
      "prerelease": false,
      "package-name": "package.json"
    }
  }
}

I have found this is the output and also tried renaming packages in the manifest to match:

⚠ Found release tag with component 'recruitment-admin-frontend', but not configured in manifest
⚠ Found release tag with component 'recruitment-backend', but not configured in manifest

They look like this:

.release-please-manifest:
{
  "recruitment-backend": "1.1.0",
  "recruitment-admin-frontend": "1.1.0"
}

release-please-config:
{
  "packages": {
    "recruitment-backend": {
      "changelog-path": "CHANGELOG.md",
      "bump-minor-pre-major": false,
      "bump-patch-for-minor-pre-major": false,
      "draft": false,
      "release-type": "node",
      "prerelease": false,
      "package-name": "package.json"
    },
    "recruitment-admin-frontend": {
      "changelog-path": "CHANGELOG.md",
      "bump-minor-pre-major": false,
      "bump-patch-for-minor-pre-major": false,
      "draft": false,
      "release-type": "node",
      "prerelease": false,
      "package-name": "package.json"
    }
  }
}

Any help would be much appreciated.

ddennis avatar Nov 05 '22 15:11 ddennis