Bryan Boreham

Results 674 comments of Bryan Boreham

I'm not sure I understand. What is the significance of looking for `$` ?

> does not contain new lines (Might be confusing: this is the result of Prometheus evaluating regexps in multi-line mode. Which is arguably a bug, but not one we can...

> This PR is optimizing the cases like this: > ``` - action: replace target: contains_no_variables replacement: contains_no_variables separator: ; // the default regex: (.*) // the default ``` If...

Please don't do that; we will be back into the newline discussion. `val == ""` guarantees we don't have to talk about newlines. `(.*)` does not match `"\n"`, for instance.

While I sympathise about wanting better notification of issues, I would be concerned about the quantity of logging this can generate. Maybe some metrics which help to identify there is...

It appears to use slightly more memory: and slightly less disk space: There are fewer chunks in memory, as expected: @leizor what metric(s) were you looking to show an improvement...

Good point. Small note: if the data is queried it will be brought back into memory. So it’s relevant that Prombench was not running any queries. (However it’s likely that...

Thanks for this PR. Could you please write some words about the requirements you intended to meet? E.g. for a rule which outputs fewer series than it inputs, how are...

> E.g. for a rule which outputs fewer series than it inputs, how are exemplars mapped from input to output series. I did not follow your answer to this question....