Bryan Boreham comments

Results 668 comments of


Bryan Boreham

promtool: Buffer piped unit test rule input to a tempfile

Hello from the bug-scrub: @dgl do you have any further thoughts?

[FEATURE] Kubernetes SD: Allow attaching namespace metadata to targets

Still got CI errors - will you take another look at those?

promql: ensure series in matrix values returned for instant queries are sorted

> Running the benchmarks We did run prombench, although it doesn't have this kind of query. I don't think there are any benchmarks which currently test the case of an...

promql: ensure series in matrix values returned for instant queries are sorted

> I couldn't find it documented anywhere. Perhaps [here](https://prometheus.io/docs/prometheus/latest/querying/api/#range-vectors) makes sense? :+1: > Should we also require instant vectors to be sorted by series as well? The code takes care...

promql: ensure series in matrix values returned for instant queries are sorted

Related: the code silently ignores any `sort` in the PromQL when returning a matrix. In my mind I imagine some heartless Prometheus maintainer gloating "they'll figure it out eventually", but...

promql: ensure series in matrix values returned for instant queries are sorted

Also related: [`sort_by_label`](https://prometheus.io/docs/prometheus/latest/querying/functions/#sort_by_label) could work for matrixes.

query: skip over missing samples for vector expressions

Does it need some test cases? Are you sure that steps in the result set are always numbered the same as steps in the input to `rangeEval` and `eval` ?

Report context cancelation as non-error

@austinlparker sorry to bug you personally, but you were the last person to merge anything in this repo. Would you be interested in handing over to someone else?