Basil Crow

Results 422 comments of Basil Crow

> at least you could preserve history/contributions from people who did the job in another PR Please see the review description: > Do _not_ review. I am not sure why...

> Seems like a personal fork of the repo would be more appropriate way to use git and github for your personal reasons. But a personal fork of the repository...

-0 from me, I hate pre-commit hooks and would much rather run a Maven command to fix up formatting when I want rather than at Git commit time. If this...

This is just personal preference. I am not against others using what works for them, but this does not work for me. I don't like it when my Git operations...

> Should I undo the cherry pick for [JENKINS-68805](https://issues.jenkins.io/browse/JENKINS-68805) and follow the instructions here? What you have done already is not incorrect but just incomplete, so to complete it you...

> How does this behave with implied and optional dependencies? What is the reason behind the asking of this question? Is there some concern that this has not been fully...

Thanks for clarifying @daniel-beck. @benebsiny Can you please perform the testing @daniel-beck has requested and update the testing section of PR description?

> So I am forced to comment my concerns without having first confirmed them. Nobody is forcing you to say anything about a feeling you have that may or not...

> I've reported 31 regressions in core so far this year, so I'd rather comment, potentially unnecessarily, than do that some more. Those who are on the receiving end of...

> @benebsiny requested a review from @daniel-beck 11 days ago Reiterating this request for @daniel-beck to confirm that the testing he requested was performed.