Benjamin Armintor
Benjamin Armintor
I'm not sure how helpful a screenshot will be here (it'll just be a transparent gray overlay div over the edit interface), but I'll see what I can do.
edit: removing the widget screenshot privacy The result of click and drag to highlight:
I can email a screenshot of the widget before it disappears if you need it.
See also `render_facet_partials`. This doesn't impact the API, correct?
Marking as 8.x as implicated refactoring is not in scope for 7.0 (and implies API issues).
Please correct me if I misunderstand, but marking as 7.x since it could be handled in a feature release.
I'm reading this as something that would impact new installs, but not the live schema of existing installs, and thus could be part of a feature release. Please correct me...
Adding for context, for people (like me!) who weren't familiar with this mechanism: https://viewcomponent.org/guide/collections.html#with_collection_parameter https://viewcomponent.org/api.html#with_collection_parameterparameter My read of the ViewComponent documentation is that removing that `with_collection_parameter` won't prevent the use...
I just want to reiterate that this PR has never removed `with_collection`, but only the collection parameter override via `with_collection_parameter` - and that the latter was what was complicating subclasses....
I think we should close this in favor of #2698 , which includes the removal of the unnecessary collection parameter specification here.