Benjamin Armintor
Benjamin Armintor
thanks for everyone's patience while I worked that ViewComponent 3 issue out!
Is this because there's no way to query the repo by type, and the permissions objects point to the objects they govern?
It looks like the `blacklight.range_limit.missing` translation is unused after https://github.com/projectblacklight/blacklight_range_limit/commit/a3fd1d412c999939089e11d4a1ed69e2d31e7672 (8.2.0+)
The `body` slot is always going to be present (in this case, a ViewComponent::Slot object), so that `render?` implementation will always return `true`. What's the desired behavior here? If the...
I understand that you don't want the header that says "Limit Your search". Whether the `FacetGroupComponent` renders at all is a related but separate implementation question that has an impact...
> It does seem like the current BL 8.0.1 FacetGroupComponent#render? is basically a no-op, and a mistake? The logic there could work if we did not provide the deprecated default...
@cgalarza I think this is what we were talking about for the Penn/Columbia use case - the changes I made to get a minimal form rendering to work in our...
I like the idea of making this configurable, but I dread a little using a helper override to do it - in part because we don't want to encourage relying...
To be clear, I totally agree with @jcoyne that it's not desirable to have this in the controller mixin; I would just go a step further and say it's better...
@jrochkind what I am suggesting is that another way to approach this, rather than "I need a way to say not to display the home partials", is to provide a...