blacklight icon indicating copy to clipboard operation
blacklight copied to clipboard

Add i18n for modal network error dialog

Open cbeer opened this issue 8 years ago • 1 comments

This error handling code is not localized:

https://github.com/projectblacklight/blacklight/blob/master/app/assets/javascripts/blacklight/modal.js#L108-L112

  var contents =  "<div class='modal-header'>" +
            "<div class='modal-title'>Network Error</div>" +
            '<button type="button" class="blacklight-modal-close close" data-dismiss="modal" aria-label="Close">' +
            '  <span aria-hidden="true">&times;</span>' +
            '</button>';

We should extract the modal title and close button to a localizable form (also, what is the happy path for localized javascript?)

cbeer avatar Feb 01 '17 15:02 cbeer

Please correct me if I misunderstand, but marking as 7.x since it could be handled in a feature release.

barmintor avatar Oct 24 '18 17:10 barmintor