Antoine Guillaume

Hey @itsdivya1309 changes looks good to me, just need to test coverage again to see if the issue is solved. Changing tags accordingly.

A drawback of our current approach is that a transformer that needs to be fitted could only be broadcasted to a set of samples from the same size. For example...

Here is a draft for using joblib, need to add some tests and sort out tags for input format, as for now the example using MatrixProfileSeriesTransformer fails because it didn't...

To-dos left for this PR before it is ready for review: - [x] Fix broadcaster test, seem to be failing some check in cases where `fit_empty=True` in the broadcasted series...

Thanks for reviewing ! Concerning your questions: > So is the essentially intended to be the parallel of https://github.com/aeon-toolkit/aeon/blob/main/aeon/transformations/collection/_collection_wrapper.py? Isn't `_collection_wrapper.py` a Collection to Series while the introduction of this...

Some notes on the updates : - Removed axis from Matrix Profile as it is expecting univariate data - Added data generation for 1D/2D series in testing utils - Added...

Agreed, then we can benchmark it to select the best solution, I'll try to make the modification tomorrow if you didn't do it before me !

> Any reason for the new base class direction? Do they other base classes not have much shared functionality? Yeah, after doing some pen and paper for the other two...

On second thought, we could call the preprocess function of the CollectionEstimator for the 3D data given during fit method in a BaseSimilaritySearch, but that's about it ... Would that...

> If there are a significant number of shared parameters/attributes/functions used then it may be a good idea to keep even if its mostly abstract methods. For some reason, I...