aeon
aeon copied to clipboard
[MNT] Update `ElasticEnsemble` test to work with all distances
Reference Issues/PRs
Tries to fix #1499
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
- [ ] I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
- [x] The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
- [ ] I've added the estimator to the online API documentation.
- [ ] (OPTIONAL) I've added myself as a
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
- [ ] (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.
Thank you for contributing to aeon
I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$ ]. Feel free to change these if they do not properly represent the PR.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit
code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeon
Slack channel if you have any.
@MatthewMiddlehurst, does this fix the issue?
Hey @itsdivya1309 changes looks good to me, just need to test coverage again to see if the issue is solved. Changing tags accordingly.
Hi, not quite what I was going for, I could have explained it better 🙂. Odd that those are excluded though, not sure why. Maybe they weren't used in the original paper?
What I wanted was for a pytest
test to be added which tests the "all"
options of the distance parameter. If you click on the coverage report in the issue, this is not currently tested.
Hi, not quite what I was going for, I could have explained it better 🙂. Odd that those are excluded though, not sure why. Maybe they weren't used in the original paper?
What I wanted was for a
pytest
test to be added which tests the"all"
options of the distance parameter. If you click on the coverage report in the issue, this is not currently tested.
Hi!
The distances were in the ElasticEnsemble
class, but not here, so I added them. I still need to check the paper, though.
I have added a test. Would this work?