Antoine Guillaume

Results 81 comments of Antoine Guillaume

I don't think that should be happening, let me check

Some changes were made to the file you are working with on #1959, which added two parameters to the `_init_random_shapelet_params` and `random_dilated_shapelet_extraction` function, which both are ndarray of integers. (need...

Yes, could you should first merge the main branch into this and had the type hints for the new parameters of the functions I listed ?

Just need to resolve the remaining conversation, and we'll be good to go I think ! 😄 (One from Matthew still need an action from you)

Thanks for the comments ! i'll look into improving the visualisation and docs for these methods in the following weeks when time allows. The informations of the shapelets array from...

Hi, Yes, the threshold is indeed used to compute the shapelet occurence (SO) feature, see [this function](https://github.com/aeon-toolkit/aeon/blob/c80baf772dcf0e60aaaae87c27d1befdef90a7b4/aeon/transformations/collection/shapelet_based/_dilated_shapelet_transform.py#L953) I've been and will be very busy until end of october so I...

Hi @ricor07, just a heads-up, this issue is a bit tricky, so if you are new to python/numba/git CI, this might not be the easiest place to start with. The...

You should find everything you need to setup your environnement and run test in the documentation. Althought the issue might be fixed by running the tests on Ubuntu only, but...

You can proceed with a PR that would remove the two test exclusion ``` "RDSTRegressor": ["check_regressor_against_expected_results"], "RISTRegressor": ["check_regressor_against_expected_results"], ``` This way we can test it on the GitHub CI to...