Antoine Guillaume
Antoine Guillaume
Hi, great question. This is should happen when the number of admissibles matches is less than k. Which can happen with small series and use of trival matches to false....
Thanks for the inputs @patrickzib😄 > For *whole series similarity search* fit requires a dataset of time series of equal length, and find_neighbors would get one or many query series...
> Simplicity :) But I agree that you could have multiple series in fit, too - this would mimic the Shapelet use case, I suppose? I'm not 100% sure what...
I'll leave the implementation of `k-motiflets` for later as a separate estimator so I can focus on getting the testing, tags and docs right for this PR to have the...
Based on your comment @MatthewMiddlehurst, I think another set of base class for neighbours / motifs estimator is necessary to not have weird thing in the series & collection base...
Tried to make additional base classes, but this made the whole module structure feel too overcomplicated. Reverted and instead factored some functions away from the base class and made a...
I think we need to explore this a bit further down the road when more estimators are added to see if it would really fit a use case. This could...
Agreed, will resume work on this module during summer when things cool down, and testing will definitly be an important part of the work
@Datadote If this one is OK for you, you can assign yourself to it !
I don't remember if we have a bot for this, but you can do it manually on the Assignees tab on the right side, I'll do it for you this...