Roman Artiukhin

To me it looks like an improvement that can wait till it's accepted by Relinq considering that affected queries can be easily fixed by moving all parts that needs in...

> I don't have a netcoreapp2.1 Well yeah - .net core 2.1 is required to be installed on PC to make async generator work

> The added Linq extension method AsAsyncEnumerable I'm pretty sure that `Enumerable.AsEnumerable` LINQ extension leads to `IQuery.List` on iteration. That makes sync counterpart quite different from async version. We either...

> I tested it and calling AsEnumerable does not execute any query, Yeah that's expected (`As` suggests that it only casts inside ) I meant on actual enumeration `IQuery.List` will...

> Do really IQuery.Enumerable needs to execute the query when called, is there a reason behind it? Did you mean `IQuery.List`? Well as far as I know `ISession.Enumerable` is not...

> Only now I realized that PerformIterate and now PerformAsyncIterate trigger N+1 queries. That sucks :( It's not very useful for entities but I guess it's still can be useful...

Yeah. I agree test case from #1252 is very weird. But in general this PR covers condition when entity is modified on loading event and this loading happens during flush...

>The test becomes green when either: >DynamicToy is set using the property That's because of stupid logic inside property setter. Yeah test is strange and I should have come up...

Actually I can't come up with anything that looks sane :) Maybe such scenarios are indeed should be considered too specific to be handled in nhibernate. So feel free to...

And Renovate auto rebasing seems also sometime is forced even when disabled :( (seems like when other renovate PR is merged)