Roman Artiukhin
Roman Artiukhin
Maybe it needs to be moved to NHibernate [pool ](https://teamcity.jetbrains.com/agents.html?tab=agentPools) first? Do you have permissions for this?
> "Canceled in 360m - Oracle" misled me Why misled? There is clearly some issue with Git Hub Action build (Oracle on Linux) - https://github.com/nhibernate/nhibernate-core/runs/7643016174?check_suite_focus=true
I think we should simply skip tests for Oracle and Sql Server on linux.
> It's something AspNet Core related, since .net5.0 console applications don't have such an issue. Well according to docs you mentioned you can still use it with ASP.NET. You just...
> I suppose the only fact you reference (somewhere in your code) the BinaryFormatter class causes the app to block at the startup. I doubt it. Can you share full...
It seems does the job but I wonder how to make it more optimal. Now expressions evaluation are duplicated inside `NhPartialEvaluatingExpressionVisitor.TryGetCollectionParameter` and as part of common parsing inside `NhPartialEvaluatingExpressionVisitor.Visit(Expression expression)`.
> Now expressions evaluation are duplicated Seems to be fixed by https://github.com/nhibernate/nhibernate-core/pull/2873/commits/15381b0a47c42f23de76b9296c303f5b7974d433
> In other words the @v-kabanov's solution is more correct. I agree. Though I don't like including another bunch of slightly modified files from Re-Linq. IMO better local small targeted...
>With the proposed implementation following expression would be considered as evaluatable: ```C# db.Orders.Where(o => ids.Where(i => i == o.OrderId).Contains(o.OrderId)) ``` Yeah. I know.. But it's not supported anyway. Old behavior:...
> Imho, there is a bug in EvaluatableTreeFindingExpressionVisitor.Analyze which marks any expression containing lambda as not evaluatable. https://re-motion.atlassian.net/browse/RMLNQ-96 It looks like it's known limitation since 2016. And here is author's...